Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoload the sidekick libraries #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Autoload the sidekick libraries #16

wants to merge 3 commits into from

Conversation

orta
Copy link
Owner

@orta orta commented Jan 29, 2017

Been having issues with the CP mac app related to some of the system imports that gh_inspector brings in CocoaPods/CocoaPods-app#376

This moves those imports to only happen during the code that needs them.

@segiddins
Copy link
Contributor

Why not use autoload instead?

@orta
Copy link
Owner Author

orta commented Jan 29, 2017

Hmmmmmm, I do not know what this is (goes off to learn)

@orta
Copy link
Owner Author

orta commented Jan 29, 2017

Ah, I see, I can replace require with autoload and it will only load those symbols when the first one is accessed. This makes sense, and should fix my issue.

@orta orta changed the title Move requires inside functions which will use the new classes Autoload the sidekick libraries Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants