chore: format generated code before committing #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
zepatrik
approved these changes
Sep 23, 2022
|
Okay let's give this a try and see what happens! |
This was referenced Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that auto-generated code isn't properly formatted, even though
make sdkformats everything it generates. To be on the safe side, this runsmake formatagain before committing the auto-generated changes. Make format should always succeed here because it already ran at this time.This also changes the Go version used for generating the SDK to Go 1.19. Keto is already at this version. I try to enforce Go 1.19 code style across all repos.
Please advise how to test this.