Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow release based on git hash #241

Merged
merged 1 commit into from
Oct 13, 2022
Merged

feat: allow release based on git hash #241

merged 1 commit into from
Oct 13, 2022

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Oct 13, 2022

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added the necessary documentation within the code base (if
    appropriate).

Further comments

Copy link
Contributor

@kevgo kevgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you document what this feature is intended for, when this should be used and when not? Could there be two releases with the same release number but different hashes, like v0.1.0-pre.0 75484 and v0.1.0-pre.0 7838? Why not make the latter one v0.1.0-pre.1?

@aeneasr
Copy link
Member Author

aeneasr commented Oct 13, 2022

We don't always want to release HEAD of master but instead a git tag form e.g. a few days ago. That's what this feature is for!

@aeneasr aeneasr merged commit fed1b03 into master Oct 13, 2022
@aeneasr aeneasr deleted the release-tag branch October 13, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants