feat: project flag accepts slug #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
zepatrik
requested changes
Jan 10, 2023
cmd/cloudx/client/handler.go
Outdated
Comment on lines
536
to
538
| if id == uuid.Nil { | ||
| return nil, errors.Errorf("No project selected! Please use the flag --project to specify one.\n") | ||
| } |
There was a problem hiding this comment.
I would move this error message to the very top of this function and make the condition projectOrSlug == "". At this point, the proper error should be similar to no project found with slug %s, only slugs %v are known. This makes it a lot easier for users to spot their mistakes.
There was a problem hiding this comment.
Thanks for the review! :)
Should the output look like this then or should we only show the closest slug?
no project found with slug romantic-kilby-g76if4751f, only slugs known are:
romantic-kilby-g76if4751e
busy-jang-bwemahrjn5
busy-black-v1msdqmms0
ecstatic-swartz-ququpvs916
peaceful-kare-ugrr1tziby
stoic-dijkstra-4x7qznhyru
There was a problem hiding this comment.
I would just print the whole list. Maybe you can use the command listing the projects instead? It should at least have a type to show projects as nice tables.
zepatrik
requested changes
Jan 10, 2023
Co-authored-by: Patrik <zepatrik@users.noreply.github.com>
Co-authored-by: Patrik <zepatrik@users.noreply.github.com>
zepatrik
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables supplying slugs to
cmd subcmd project PROJECTORSLUG/cmd ls identities PROJECTORSLUG.Related Issue or Design Document
closes #267
closes #156
Checklist
and signed the CLA.
introduces a new feature.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
appropriate).
Further comments