Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add open ax pages #295

Merged
merged 23 commits into from
Jan 26, 2023
Merged

feat: add open ax pages #295

merged 23 commits into from
Jan 26, 2023

Conversation

tilschuenemann
Copy link
Contributor

This PR enables the CLI to open the account experience pages.

Related Issue or Design Document

#269

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added the necessary documentation within the code base (if
    appropriate).

Further comments

@tilschuenemann tilschuenemann marked this pull request as ready for review January 20, 2023 11:24
@aeneasr
Copy link
Member

aeneasr commented Jan 20, 2023

Have you tested this manually? Does it work on all operating systems like macOS and windows too?

@tilschuenemann
Copy link
Contributor Author

I've used the browser package which works cross platform. Tested manually on Ubuntu.

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :) LGTM

@aeneasr aeneasr merged commit 3c66191 into master Jan 26, 2023
@aeneasr aeneasr deleted the open-ax branch January 26, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants