feat: event-streams: create, update, list, delete #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas-jonas
reviewed
Jan 17, 2024
|
|
||
| func NewCreateEventStreamCmd() *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "event-stream [--project=PROJECT_ID] --type=sns --aws-iam-role-arn=arn:aws:iam::123456789012:role/MyRole --aws-sns-topic-arn=arn:aws:sns:us-east-1:123456789012:MyTopic", |
There was a problem hiding this comment.
If a flag is required, shouldn't it be a positional argument instead?
There was a problem hiding this comment.
Is that a rule? Considering you need to provide a bunch of info, that’d get complicated real quick.
There was a problem hiding this comment.
Not really a rule, just feels weird to have required flags in a CLI application. But I agree, the values are probably too convoluted to make them positional arguments.
There was a problem hiding this comment.
Just to weigh in with my anecdotal opinion, I like flags here because they are more documenting that just a huge list of positional arguments.
jonas-jonas
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/ory-corp/cloud/issues/5696