Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add document for lark oidc provider #1145

Merged
merged 8 commits into from
Dec 22, 2022
Merged

Conversation

CNLHC
Copy link
Contributor

@CNLHC CNLHC commented Dec 6, 2022

Needs ory/kratos#2925

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@CNLHC CNLHC changed the title feat: add document for lark feat: add document for lark oidc provider Dec 6, 2022
@CNLHC CNLHC mentioned this pull request Dec 6, 2022
7 tasks
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
I have a few suggestions, mostly grammar

docs/kratos/social-signin/81_lark.mdx Outdated Show resolved Hide resolved
docs/kratos/social-signin/81_lark.mdx Outdated Show resolved Hide resolved
docs/kratos/social-signin/81_lark.mdx Outdated Show resolved Hide resolved
Co-authored-by: Vincent <vincent@ory.sh>
@vercel
Copy link

vercel bot commented Dec 7, 2022

@CNLHC is attempting to deploy a commit to the ory Team on Vercel.

A member of the Team first needs to authorize it.

CNLHC and others added 2 commits December 7, 2022 21:27
Co-authored-by: Vincent <vincent@ory.sh>
Co-authored-by: Vincent <vincent@ory.sh>
@CNLHC
Copy link
Contributor Author

CNLHC commented Dec 7, 2022

Thanks for the contribution! I have a few suggestions, mostly grammar

Thanks for your review.

Copy link
Contributor

@tomekpapiernik tomekpapiernik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, pls have a look at my comment - I'm not sure if that's part of the name of the platform or something that shouldn't be there

docs/kratos/social-signin/81_lark.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@tomekpapiernik tomekpapiernik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix :) Good to merge when the code is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants