-
-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add document for lark oidc provider #1145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
I have a few suggestions, mostly grammar
Co-authored-by: Vincent <vincent@ory.sh>
@CNLHC is attempting to deploy a commit to the ory Team on Vercel. A member of the Team first needs to authorize it. |
Co-authored-by: Vincent <vincent@ory.sh>
Co-authored-by: Vincent <vincent@ory.sh>
Thanks for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay, pls have a look at my comment - I'm not sure if that's part of the name of the platform or something that shouldn't be there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix :) Good to merge when the code is merged.
Needs ory/kratos#2925
Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
Further comments