Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clarify generic OIDC provider issuer behaviour #1642

Merged
merged 2 commits into from
Mar 1, 2024
Merged

fix: clarify generic OIDC provider issuer behaviour #1642

merged 2 commits into from
Mar 1, 2024

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Feb 13, 2024

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@vinckr vinckr requested a review from aeneasr as a code owner February 13, 2024 12:43
hperl
hperl previously approved these changes Feb 13, 2024
View reviewed changes
@vinckr vinckr enabled auto-merge (squash) February 13, 2024 12:51
aeneasr
aeneasr previously approved these changes Mar 1, 2024
View reviewed changes
@aeneasr
Copy link
Member

aeneasr commented Mar 1, 2024

Please resolve conflicts :)

@vinckr vinckr dismissed stale reviews from aeneasr and hperl via 50a53a1 March 1, 2024 08:01
@vinckr vinckr requested a review from aeneasr March 1, 2024 08:01
@vinckr vinckr merged commit 42e3d07 into master Mar 1, 2024
9 checks passed
@vinckr vinckr deleted the generic-oidc-provider-userinfo-issuer branch March 1, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr aeneasr approved these changes

@hperl hperl hperl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinckr @aeneasr @hperl