Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: document workspace API keys #1758

Merged
merged 7 commits into from
Jul 3, 2024
Merged

feat: document workspace API keys #1758

merged 7 commits into from
Jul 3, 2024

Conversation

hperl
Copy link
Collaborator

@hperl hperl commented Jun 14, 2024

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@hperl hperl self-assigned this Jun 14, 2024
@vinckr vinckr added the upstream Issue is caused by an upstream dependency. label Jun 17, 2024
jonas-jonas
jonas-jonas requested changes Jun 19, 2024
View reviewed changes
docs/concepts/personal-access-token.mdx Show resolved Hide resolved
docs/concepts/personal-access-token.mdx Outdated Show resolved Hide resolved
@hperl hperl requested a review from jonas-jonas June 20, 2024 07:00
jonas-jonas
jonas-jonas previously approved these changes Jun 20, 2024
View reviewed changes
vinckr
vinckr previously approved these changes Jun 20, 2024
View reviewed changes
piotrmsc
piotrmsc reviewed Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@piotrmsc piotrmsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for describing it :) I think it is going into a good direction but it needs a few last touches.

docs/concepts/personal-access-token.mdx Show resolved Hide resolved
docs/concepts/personal-access-token.mdx Show resolved Hide resolved
@hperl hperl dismissed stale reviews from vinckr and jonas-jonas via 4c88b72 June 27, 2024 11:46
@hperl hperl requested a review from piotrmsc June 27, 2024 11:46
@hperl hperl force-pushed the hperl/workspace-api-keys branch from aa545ab to c8e42d5 Compare July 2, 2024 07:56
@hperl hperl requested a review from piotrmsc July 2, 2024 09:00
piotrmsc
piotrmsc approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@piotrmsc piotrmsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@hperl hperl merged commit 49fe41c into master Jul 3, 2024
9 checks passed
@hperl hperl deleted the hperl/workspace-api-keys branch July 3, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrmsc piotrmsc piotrmsc approved these changes

@vinckr vinckr vinckr left review comments

@jonas-jonas jonas-jonas jonas-jonas left review comments

@aeneasr aeneasr Awaiting requested review from aeneasr aeneasr is a code owner

@zepatrik zepatrik Awaiting requested review from zepatrik zepatrik is a code owner

Assignees

@hperl hperl

Labels
upstream Issue is caused by an upstream dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hperl @jonas-jonas @piotrmsc @vinckr