Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sidebar ids/slugs #1858

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix: sidebar ids/slugs #1858

merged 1 commit into from
Sep 3, 2024

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Sep 1, 2024

fixes issues from #1823

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@vinckr
Copy link
Member Author

vinckr commented Sep 2, 2024

@aeneasr fix for the broken pages in docs.
can you tell me why the build didn't succeed - it works locally

@aeneasr
Copy link
Member

aeneasr commented Sep 2, 2024

You should see it if you run npm run build - apparently a broken link somewhere

@vinckr
Copy link
Member Author

vinckr commented Sep 2, 2024

Yea as I said the build works locally.

I get a lot of broken anchors but they are no issue.

[SUCCESS] Generated static files in "build".

I cant access the vercel logs so not sure what is the issue.

@vinckr
Copy link
Member Author

vinckr commented Sep 2, 2024

ok now this should revert any changes to the slugs/urls (+ a some small fixes)

@aeneasr aeneasr merged commit 2a85abf into master Sep 3, 2024
9 checks passed
@aeneasr aeneasr deleted the vinckr/fix-sidebar-ids branch September 3, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants