-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React and Preact example does not handle error code 422 #53
Labels
bug
Something isn't working
Comments
misamu
added a commit
to misamu/ory-elements
that referenced
this issue
Jan 18, 2023
* style: format
misamu
added a commit
to misamu/ory-elements
that referenced
this issue
Jan 18, 2023
* fix: Implement error handling * refactor: Replicate function flow from react * style: format
This was referenced Jan 18, 2023
misamu
added a commit
to misamu/ory-elements
that referenced
this issue
Jan 23, 2023
* style: format
Benehiko
pushed a commit
that referenced
this issue
Jan 24, 2023
* fix: Error handling for react-spa 422 code (#53) * style: format * fix: format * refactor: remove redundant promise returns * feat: add basic error page * feat: api call generic error handling * fix: show error page on dashboard session errors * fix: change default signupURL to /registration * fix: create flow updates uri query param flow * fix: format * fix: show ui messages in view * fix: sdk navigate target and options * fix: remove debug
Benehiko
added a commit
that referenced
this issue
Jan 26, 2023
* fix: package.json build:preact script * fix: Error handling for 422 code (#53) * fix: Implement error handling * refactor: Replicate function flow from react * style: format * fix: format * feat: api call generic error handling * feat: add basic error page * fix: change default signupURL to /registration * fix: change /signup to default kratos /registration Co-authored-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com> Co-authored-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
This can now be closed :) Thank you @misamu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Preflight checklist
Describe the bug
On flows that could result in an error with status code 422 we would want to redirect the user to that page or at least use some of the url data such as the flow id to retrieve the necessary data to complete the flow.
Example:
Another place where this exists is Registration and Settings page with passwordless and oidc.
Reproducing the bug
Try link an oidc provider in the account settings page.
Additional Context
elements/examples/react-spa/src/Login.tsx
Line 32 in 9713065
elements/examples/react-spa/src/Login.tsx
Line 71 in 9713065
We have some functions covering this already:
The text was updated successfully, but these errors were encountered: