Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: "Secure microservices with Kong and Ory" docker-compose.yml issues #34

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

tsagkase
Copy link
Contributor

Fixed a couple of issues with kratos-oathkeeper-kong example.

  1. Docker image kong:latest breaks kratos-oathkeeper-kong example by having the kong containers exit. Now pinned to kong:2.7.2 which probably was latest when you coded the example seems to work. The relevant container logs:
    $ docker logs kratos-oathkeeper-kong-kong-1 2>&1 | tail -1
    exec /docker-entrypoint.sh: no such file or directory

The same complaint comes up with the platform: linux/arm64 directive and was removed from docker-compose.yml.

  1. The hello microservice image did not contain a binary as it failed to build due to missing CGO_ENABLED=0 build directive.

Related Issue or Design Document

The PR concerns a fix to the code linked to by the Secure microservices with Kong and Ory tutorial.

The relevant GitHub issue is #33.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact security@ory.sh) from the
    maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation within the code base (if appropriate).

Further comments

Docker image pinning is probably a safe practice.

Evangelos Tsagkas added 2 commits June 27, 2022 18:36
The fix concerns `kratos-oathkeeper-kong` guide.
`kong:latest` fails to spawn kong.
Likewise for platform arm64.

The fix concerns `kratos-oathkeeper-kong` guide.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Evangelos Tsagkas seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@vinckr vinckr requested a review from gen1us2k June 28, 2022 12:39
Copy link
Contributor

@gen1us2k gen1us2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gen1us2k gen1us2k merged commit 380e922 into ory:master Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants