removed implicit storage as its never used, #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Boke <michael.boke@gmail.com>
|
Thanks! |
matthewhartstonge
added a commit
to matthewhartstonge/storage
that referenced
this pull request
May 30, 2018
…lic API. Removed: - request: Removed CreateImplicitAccessTokenSession function as per github issue [removed implicit storage as its never used](ory/fosite#171) - storage_mongo: Removed CreateImplicitAccessTokenSession function as per github issue [removed implicit storage as its never used](ory/fosite#171)
matthewhartstonge
added a commit
to matthewhartstonge/storage
that referenced
this pull request
May 31, 2018
Added: - client: Tests to ensure storage implements fosite interfaces correctly - request: Tests to ensure storage implements oauth2 interfaces correctly - request: Tests to ensure storage implements openid interfaces correctly - readme: compatibility table Changed: - license: updated year, added github link. - mongo: conformed collection names to match javascript naming conventions (camelCase) - deps: changed dependency manager to dep - ci: changed TravisCI dependency manager to dep - file naming: removed package name pre-pending to file names. Fixed: - Tested against upstream fosite@v0.12.0 - Tested against upstream fosite@v0.13.0 - Tested against upstream fosite@v0.14.0 - Tested against upstream fosite@v0.15.0 - Tested against upstream fosite@v0.16.0 Removed: - request: Removed CreateImplicitAccessTokenSession function as per github issue [removed implicit storage as its never used](ory/fosite#171) - storage_mongo: Removed CreateImplicitAccessTokenSession function as per github issue [removed implicit storage as its never used](ory/fosite#171)
matthewhartstonge
added a commit
to matthewhartstonge/storage
that referenced
this pull request
May 31, 2018
Added: - client: Tests to ensure storage implements fosite interfaces correctly - request: Tests to ensure storage implements oauth2 interfaces correctly - request: Tests to ensure storage implements openid interfaces correctly - readme: compatibility table Changed: - license: updated year, added github link. - mongo: conformed collection names to match javascript naming conventions (camelCase) - deps: changed dependency manager to dep - ci: changed TravisCI dependency manager to dep - file naming: removed package name pre-pending to file names. Fixed: - Tested against upstream fosite@v0.12.0 - Tested against upstream fosite@v0.13.0 - Tested against upstream fosite@v0.14.0 - Tested against upstream fosite@v0.15.0 - Tested against upstream fosite@v0.16.0 Removed: - request: Removed CreateImplicitAccessTokenSession function as per github issue [removed implicit storage as its never used](ory/fosite#171) - storage_mongo: Removed CreateImplicitAccessTokenSession function as per github issue [removed implicit storage as its never used](ory/fosite#171)
budougumi0617
added a commit
to budougumi0617/fosite
that referenced
this pull request
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue #165, removed the unused storage interface