Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable PKCE for private clients #382

Merged
merged 3 commits into from
Sep 16, 2019
Merged

Enable PKCE for private clients #382

merged 3 commits into from
Sep 16, 2019

Conversation

damienbr
Copy link
Contributor

@damienbr damienbr commented Sep 16, 2019

Related issue

#1512
@aeneasr

Proposed changes

Remove the checks in PKCE flow that limits the feature to Public clients only.

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)

Further comments

@CLAassistant
Copy link

CLAassistant commented Sep 16, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ damienbr
❌ loicvigneron
You have signed the CLA already but the status is still pending? Let us recheck it.

@aeneasr
Copy link
Member

aeneasr commented Sep 16, 2019

Awesome - thank you! :)

@nerocrux
Copy link
Contributor

Great! Love this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants