Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new function to TokenRevocationStorage to support refresh token grace-period #635

Merged
merged 3 commits into from Jan 6, 2022

Conversation

bill-robbins-ss
Copy link
Contributor

@bill-robbins-ss bill-robbins-ss commented Oct 29, 2021

Add a new function to the Token Revocation Storage interface that is called during a refresh token flow.

See ory/hydra#2827 for details on this feature.

Related Issue or Design Document

#255
Hydra 1831

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added necessary documentation within the code base (if
    appropriate).

Further comments

@bill-robbins-ss bill-robbins-ss marked this pull request as ready for review November 1, 2021 20:22
@bill-robbins-ss bill-robbins-ss changed the title add new function to TokenRevocationStorage to support RT grace-period feat: add new function to TokenRevocationStorage to support refresh token grace-period Nov 2, 2021
storage/memory.go Outdated Show resolved Hide resolved
@aeneasr
Copy link
Member

aeneasr commented Dec 22, 2021

Are you still up for the changes? 🧐 If you need any help, let us know!

I'll convert this to a draft in the meanwhile. When it's ready for review again, please remove the draft indicator! 👀

@aeneasr aeneasr marked this pull request as draft December 22, 2021 14:59
@bill-robbins-ss
Copy link
Contributor Author

Hey @aeneasr I was ready for a merge. What changes are requested ?

@aeneasr
Copy link
Member

aeneasr commented Dec 26, 2021

@bill-robbins-ss in case you missed the comment: #635 (comment)

@aeneasr aeneasr marked this pull request as ready for review December 26, 2021 15:33
@bill-robbins-ss
Copy link
Contributor Author

Hey @aeneasr I got it, taking some time off before the new year then I'll catch everything up. Thanks !

@aeneasr
Copy link
Member

aeneasr commented Dec 27, 2021

Awesome! Enjoy the time off the digital world and with your family & loved ones :) Looking forward to have you back when you're back! :)

@aeneasr aeneasr merged commit 9b40d03 into ory:master Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants