Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SDK generation at Makefile #1954

Merged
merged 4 commits into from
Jul 20, 2020
Merged

fix: SDK generation at Makefile #1954

merged 4 commits into from
Jul 20, 2020

Conversation

sawadashota
Copy link
Contributor

@sawadashota sawadashota commented Jul 17, 2020

Proposed changes

Fix SDK generation at Makefile because of many unexpected diff.

I referred to ory/sdk.
https://circleci.com/orbs/registry/orb/ory/sdk#orb-source

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

This PR includes some diff at SDK. Is it expected behavior?

Signed-off-by: sawadashota <xiootas@gmail.com>
Makefile Outdated
cli dev swagger sanitize ./.schema/api.swagger.json
swagger flatten --with-flatten=remove-unused -o ./.schema/api.swagger.json ./.schema/api.swagger.json
swagger validate ./.schema/api.swagger.json
rm -rf internal/httpclient
mkdir -p internal/httpclient
swagger generate client -f ./.schema/api.swagger.json -t internal/httpclient -A Ory_Hydra
make format
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-add this :)

Signed-off-by: sawadashota <xiootas@gmail.com>
Signed-off-by: sawadashota <xiootas@gmail.com>
Signed-off-by: sawadashota <xiootas@gmail.com>
@aeneasr aeneasr merged commit e7a8322 into ory:master Jul 20, 2020
@aeneasr
Copy link
Member

aeneasr commented Jul 20, 2020

Thank you!

@sawadashota sawadashota deleted the make_sdk branch July 20, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants