Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added new tracer ElasticAPM #2155

Merged
merged 5 commits into from
Nov 9, 2020
Merged

feat: added new tracer ElasticAPM #2155

merged 5 commits into from
Nov 9, 2020

Conversation

monwolf
Copy link
Contributor

@monwolf monwolf commented Nov 1, 2020

Related issue

I don't created the issue, but I have the necessity to be able to trace with this APM: ORY Hydra

Proposed changes

Added the capability to trace Hydra with Elastic APM

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation within the code base (if appropriate).

Further comments

To make it work, you should declare at least ELASTIC_APM_SERVER_URL and TRACING_PROVIDER=elastic-apm

  # - ELASTIC_APM_SERVER_URL="http://apm-server:8200"
  # - ELASTIC_APM_SERVICE_NAME="ORY Hydra"
  # - ELASTIC_APM_SERVICE_VERSION="1.9.0"
  # - ELASTIC_APM_ENVIRONMENT="devel"

The result should be:

image

@monwolf
Copy link
Contributor Author

monwolf commented Nov 3, 2020

@aeneasr I've updated the version of ory/x and now it's compiling and passing the tests well in Hydra, I think this PR is ready to merge it

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow turnover - thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants