-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve delete queries for janitor command #2540
Commits on May 20, 2021
-
perf(janitor): improve delete queries
Improve delete queries by separating the data extraction from actual delete. Extraction is made with a configurable limit, using --limit flag, then deletes are made in batch mode with a configurable batch size, using --batch-size flag. Default value for limit is 100000 records and default value for batch size is 100 records.
Configuration menu - View commit details
-
Copy full SHA for 5baea31 - Browse repository at this point
Copy the full SHA 5baea31View commit details -
fix(janitor): include unhandled requests in login and consent cleanup
This uses LEFT JOIN to select also login and consent requests which did not result in a complete authentication, i.e. user requested login but timed out or user logged in and timed out at consent.
Configuration menu - View commit details
-
Copy full SHA for 8b6cb9e - Browse repository at this point
Copy the full SHA 8b6cb9eView commit details -
fix(janitor): split login and consent requests extraction
This splits in two independent SELECTs the extraction of login and consent requests eligible for deletion. This solves a bug in the single SELECT causing deletion of consent requests where matching login requests were eligible for deletion and vice versa. With independent SELECTs we keep consent requests even if matching login request gets deleted and vice versa.
Configuration menu - View commit details
-
Copy full SHA for 6943655 - Browse repository at this point
Copy the full SHA 6943655View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5bd252 - Browse repository at this point
Copy the full SHA d5bd252View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b27346 - Browse repository at this point
Copy the full SHA 1b27346View commit details
Commits on May 21, 2021
-
test: ensure that user is passing limit and batch size greater than 0
This adds a check in janitor command handler to ensure that user is not passing wrong values for limit anch batch flags. This also adds tests for these command line arguments.
Configuration menu - View commit details
-
Copy full SHA for d55622b - Browse repository at this point
Copy the full SHA d55622bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b5b0791 - Browse repository at this point
Copy the full SHA b5b0791View commit details
Commits on Jun 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for e526182 - Browse repository at this point
Copy the full SHA e526182View commit details -
Configuration menu - View commit details
-
Copy full SHA for 254a271 - Browse repository at this point
Copy the full SHA 254a271View commit details -
fix(janitor): ensure that records to delete are selected in order
This fix avoids unexpected behaviors if the janitor cli is executed in parallel. In that case, if we do not order records to delete, we might incur in duplicate deletes.
Configuration menu - View commit details
-
Copy full SHA for 744b1c5 - Browse repository at this point
Copy the full SHA 744b1c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for e77b610 - Browse repository at this point
Copy the full SHA e77b610View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8157887 - Browse repository at this point
Copy the full SHA 8157887View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84a7794 - Browse repository at this point
Copy the full SHA 84a7794View commit details
Commits on Jul 16, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 0ff8afe - Browse repository at this point
Copy the full SHA 0ff8afeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9103f42 - Browse repository at this point
Copy the full SHA 9103f42View commit details
Commits on Jul 17, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b54d3e4 - Browse repository at this point
Copy the full SHA b54d3e4View commit details
Commits on Jul 18, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 12661f2 - Browse repository at this point
Copy the full SHA 12661f2View commit details