refactor: generated UUID variant & version test #2793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grantzvolsky
commented
Oct 13, 2021
| @@ -82,7 +77,8 @@ func TestMigrations(t *testing.T) { | |||
| actual := &client.Client{} | |||
| outfacingID := fmt.Sprintf("client-%04d", i) | |||
| require.NoError(t, c.Where("id = ?", outfacingID).First(actual)) | |||
| assertUUID(t, &actual.ID) | |||
| require.Equal(t, actual.ID.Version(), uuid.V4) | |||
There was a problem hiding this comment.
Would it be preferable to reuse assertUUID form above?
There was a problem hiding this comment.
Fixed in commit 7054856. Please let me know it that works, in particular the placement in internal/testhelpers/uuid. The testhelpers/uuid package was necessary to avoid an import cycle in testhelpers
Codecov Report
@@ Coverage Diff @@
## v2.x #2793 +/- ##
=======================================
Coverage ? 52.88%
=======================================
Files ? 237
Lines ? 14193
Branches ? 0
=======================================
Hits ? 7506
Misses ? 6054
Partials ? 633 Continue to review full report at Codecov.
|
grantzvolsky
added a commit
to grantzvolsky/hydra
that referenced
this pull request
Feb 7, 2022
grantzvolsky
added a commit
to grantzvolsky/hydra
that referenced
this pull request
Mar 8, 2022
grantzvolsky
added a commit
that referenced
this pull request
May 19, 2022
aeneasr
pushed a commit
that referenced
this pull request
Jun 27, 2022
grantzvolsky
added a commit
that referenced
this pull request
Aug 1, 2022
aeneasr
pushed a commit
that referenced
this pull request
Aug 1, 2022
aeneasr
pushed a commit
that referenced
this pull request
Aug 18, 2022
aeneasr
pushed a commit
that referenced
this pull request
Sep 5, 2022
aeneasr
pushed a commit
that referenced
this pull request
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
#2792
@aeneasr
Checklist
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments