-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: async backchannel logout #2849
Conversation
04545a7
to
88819a7
Compare
88819a7
to
8f3bd29
Compare
8f3bd29
to
2db94c6
Compare
Codecov Report
@@ Coverage Diff @@
## master #2849 +/- ##
==========================================
- Coverage 79.64% 79.41% -0.24%
==========================================
Files 112 112
Lines 7955 7885 -70
==========================================
- Hits 6336 6262 -74
- Misses 1217 1222 +5
+ Partials 402 401 -1
Continue to review full report at Codecov.
|
8a65086
to
108a8a2
Compare
108a8a2
to
c0829aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this PR is somewhat broken? There is only one file that has changes unrelated to the PR's title
nvm :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense! Could you please add some documentation that explains that this runs async?
16fd4a8
to
313cb5f
Compare
313cb5f
to
53a5a05
Compare
…hannel-logout # Conflicts: # consent/strategy_default.go
This pull request introduces feature to execute backchannel logout asynchronously.
Use case: User should not have to wait for backchannel requests to finish (4x30sec, with potential connection timeout 1min on each request), when performing logout from all applications using GET /oauth2/sessions/logout or from specific application by using DELETE /oauth2/auth/sessions/consent?trigger_backchannel_logout=true (#2844)
Will add configuration option if needed.
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments
Tests and documentation will be commited after inital acceptance of the proposed feature.