Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: async backchannel logout #2849

Merged
merged 3 commits into from
Apr 28, 2022

Conversation

aarmam
Copy link
Contributor

@aarmam aarmam commented Nov 10, 2021

This pull request introduces feature to execute backchannel logout asynchronously.

Use case: User should not have to wait for backchannel requests to finish (4x30sec, with potential connection timeout 1min on each request), when performing logout from all applications using GET /oauth2/sessions/logout or from specific application by using DELETE /oauth2/auth/sessions/consent?trigger_backchannel_logout=true (#2844)

Will add configuration option if needed.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Tests and documentation will be commited after inital acceptance of the proposed feature.

@aarmam aarmam requested a review from aeneasr as a code owner November 10, 2021 10:24
@aarmam aarmam changed the title Feature/async backchannel logout feat: async backchannel logout Nov 10, 2021
@aarmam aarmam marked this pull request as draft November 11, 2021 13:00
@aarmam aarmam force-pushed the feature/async-backchannel-logout branch from 04545a7 to 88819a7 Compare November 24, 2021 08:29
@aarmam aarmam force-pushed the feature/async-backchannel-logout branch from 88819a7 to 8f3bd29 Compare December 8, 2021 09:53
@aarmam aarmam force-pushed the feature/async-backchannel-logout branch from 8f3bd29 to 2db94c6 Compare March 15, 2022 12:26
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #2849 (cc60449) into master (1590542) will decrease coverage by 0.23%.
The diff coverage is n/a.

❗ Current head cc60449 differs from pull request most recent head c1161aa. Consider uploading reports for the commit c1161aa to get more accurate results

@@            Coverage Diff             @@
##           master    #2849      +/-   ##
==========================================
- Coverage   79.64%   79.41%   -0.24%     
==========================================
  Files         112      112              
  Lines        7955     7885      -70     
==========================================
- Hits         6336     6262      -74     
- Misses       1217     1222       +5     
+ Partials      402      401       -1     
Impacted Files Coverage Δ
consent/strategy_default.go 69.48% <ø> (-1.04%) ⬇️
oauth2/handler.go 68.27% <ø> (ø)
cmd/cli/handler_janitor.go 78.88% <0.00%> (-2.73%) ⬇️
oauth2/trust/handler.go 75.86% <0.00%> (-0.41%) ⬇️
persistence/sql/persister_grant_jwk.go 81.08% <0.00%> (-0.34%) ⬇️
hsm/manager_nohsm.go 0.00% <0.00%> (ø)
oauth2/trust/manager.go 100.00% <0.00%> (ø)
oauth2/trust/validator.go 100.00% <0.00%> (ø)
oauth2/fosite_store_helpers.go 100.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 152bddd...c1161aa. Read the comment docs.

@aarmam aarmam force-pushed the feature/async-backchannel-logout branch 2 times, most recently from 8a65086 to 108a8a2 Compare March 23, 2022 08:17
@aarmam aarmam marked this pull request as ready for review March 23, 2022 08:39
@aarmam aarmam force-pushed the feature/async-backchannel-logout branch from 108a8a2 to c0829aa Compare March 25, 2022 12:01
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this PR is somewhat broken? There is only one file that has changes unrelated to the PR's title

nvm :)

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense! Could you please add some documentation that explains that this runs async?

@aarmam aarmam marked this pull request as draft April 6, 2022 10:33
@aarmam aarmam force-pushed the feature/async-backchannel-logout branch from 16fd4a8 to 313cb5f Compare April 12, 2022 17:48
@aarmam aarmam marked this pull request as ready for review April 12, 2022 18:13
@aarmam aarmam force-pushed the feature/async-backchannel-logout branch from 313cb5f to 53a5a05 Compare April 19, 2022 07:56
@aarmam aarmam requested a review from aeneasr April 19, 2022 12:52
aeneasr
aeneasr previously approved these changes Apr 28, 2022
…hannel-logout

# Conflicts:
#	consent/strategy_default.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants