Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support issuer with and without trailing slash #3151

Merged
merged 5 commits into from
Jun 14, 2022
Merged

fix: support issuer with and without trailing slash #3151

merged 5 commits into from
Jun 14, 2022

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jun 14, 2022

BREAKING CHANGE: The iss (issuer) value no longer appends a trailing slash but instead uses the raw value set in the config.

Setting

urls:
  self:
    issuer: https://auth.example.com

has changed

-  "iss": "https://auth.example.com/"
+  "iss": "https://auth.example.com"

To set a trailing slash make sure to set it in the config value:

urls:
  self:
    issuer: https://auth.example.com/

Closes #1482

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I am following the contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security.
    vulnerability, I confirm that I got green light (please contact security@ory.sh) from the
    maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added or changed the documentation.

Further Comments

BREAKING CHANGE: The `iss` (issuer) value no longer appends a trailing slash but instead uses the raw value set in the config.

Setting

```yaml
urls:
  self:
    issuer: https://auth.example.com
```

has changed

```patch
-  "iss": "https://auth.example.com/"
+  "iss": "https://auth.example.com"
```

To set a trailing slash make sure to set it in the config value:

```yaml
urls:
  self:
    issuer: https://auth.example.com/
```

Closes #1482
@aeneasr aeneasr marked this pull request as ready for review June 14, 2022 09:22
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

❗ No coverage uploaded for pull request base (v2.x@f6881c3). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             v2.x    #3151   +/-   ##
=======================================
  Coverage        ?   79.11%           
=======================================
  Files           ?      114           
  Lines           ?     8484           
  Branches        ?        0           
=======================================
  Hits            ?     6712           
  Misses          ?     1382           
  Partials        ?      390           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6881c3...8037102. Read the comment docs.

@aeneasr aeneasr self-assigned this Jun 14, 2022
@aeneasr aeneasr merged commit ef27780 into v2.x Jun 14, 2022
@aeneasr aeneasr deleted the fix-1482 branch June 14, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant