feat: allow skipping the consent flow #3451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3451 +/- ##
==========================================
+ Coverage 76.81% 76.83% +0.02%
==========================================
Files 123 123
Lines 9069 9069
==========================================
+ Hits 6966 6968 +2
+ Misses 1660 1659 -1
+ Partials 443 442 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hperl
force-pushed
the
hperl/skip-consent-flow
branch
from
75796db
to
87e9ad1
Compare
hperl
force-pushed
the
hperl/skip-consent-flow
branch
3 times, most recently
from
71072a3
to
8183092
Compare
6 tasks
hperl
force-pushed
the
hperl/skip-consent-flow
branch
from
8183092
to
b383582
Compare
This adds a new boolean parameter `skip_consent` to the admin APIs of the OAuth clients. This parameter will be forwarded to the consent app as `client.skip_consent`. It is up to the consent app to act on this parameter, but the canonical implementation accepts the consent on the user's behalf, similar to when `skip` is set.
hperl
force-pushed
the
hperl/skip-consent-flow
branch
from
b383582
to
23e08bc
Compare
kmherrmann
approved these changes
Mar 1, 2023
alnr
requested changes
Mar 1, 2023
| @@ -12,7 +12,7 @@ import ( | |||
| "github.com/gobuffalo/pop/v6" | |||
| "github.com/gofrs/uuid" | |||
|
|
|||
| jose "gopkg.in/square/go-jose.v2" // Naming the dependency jose is important for go-swagger to work, see https://github.com/go-swagger/go-swagger/issues/1587 | |||
| "gopkg.in/square/go-jose.v2" // Naming the dependency jose is important for go-swagger to work, see https://github.com/go-swagger/go-swagger/issues/1587 | |||
There was a problem hiding this comment.
This change seems to conflict with the comment
There was a problem hiding this comment.
Yea IDK, my IDE (Goland) does this automatically. I think this is not needed anyways (because the package is named jose already), but we can remove the comment. OK?
Comment on lines
+1376
to
+1377
| var ret bool | ||
| return ret |
There was a problem hiding this comment.
Suggested change
| var ret bool | |
| return ret | |
| return false |
There was a problem hiding this comment.
This is generated code.
aeneasr
approved these changes
Mar 2, 2023
|
how to use skip_consent? |
harnash
pushed a commit
to Wikia/ory-hydra
that referenced
this pull request
Apr 12, 2023
This adds a new boolean parameter `skip_consent` to the admin APIs of the OAuth clients. This parameter will be forwarded to the consent app as `client.skip_consent`. It is up to the consent app to act on this parameter, but the canonical implementation accepts the consent on the user's behalf, similar to when `skip` is set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments