Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle double submit logout verifier gracefully #3675

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Dec 12, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl requested a review from aeneasr as a code owner December 12, 2023 15:17
@hperl hperl requested review from alnr and zepatrik December 12, 2023 15:17
@hperl hperl self-assigned this Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (24c3be5) 75.87% compared to head (66435e1) 76.01%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3675      +/-   ##
==========================================
+ Coverage   75.87%   76.01%   +0.14%     
==========================================
  Files         134      134              
  Lines       10075    10077       +2     
==========================================
+ Hits         7644     7660      +16     
+ Misses       1914     1905       -9     
+ Partials      517      512       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr merged commit 5133cf9 into master Dec 13, 2023
32 checks passed
@aeneasr aeneasr deleted the hperl/fix-double-submit-logout-verifier branch December 13, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants