Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oauth2: Fixes clients being able to revoke any token #677

Merged
merged 3 commits into from
Dec 4, 2017
Merged

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Dec 4, 2017

Currently, it is possible to revoke tokens using any client. This PR requires the client making the revokation request to be the same as the one from the OAuth2 request.

The authorization server first validates the client credentials (in
case of a confidential client) and then verifies whether the token
was issued to the client making the revocation request. If this
validation fails, the request is refused and the client is informed
of the error by the authorization server as described below.

Upstream http://github.com/ory/fosite/issues/225

@aeneasr aeneasr added bug Something is not working. package/oauth2 vulnerability labels Dec 4, 2017
@aeneasr aeneasr added this to the 0.10.0 milestone Dec 4, 2017
@aeneasr aeneasr self-assigned this Dec 4, 2017
@aeneasr aeneasr merged commit df8e6eb into master Dec 4, 2017
@aeneasr aeneasr deleted the upgrade-fosite branch December 4, 2017 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working. package/oauth2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant