Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hydra client jwks uri #628

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

Jorgagu
Copy link
Contributor

@Jorgagu Jorgagu commented Jul 30, 2023

Update Hydra Maestro oauth2clients CR spec to add the jwks uri field for the client.
Waiting ory/hydra-maester#126 to be merged.

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@Jorgagu Jorgagu force-pushed the feat/add-hydra-client-jwks-uri branch from 1bd68ca to 363704b Compare August 9, 2023 19:44
@Jorgagu Jorgagu marked this pull request as ready for review August 9, 2023 19:51
@Demonsthere
Copy link
Collaborator

We need to wait with this until I make a full release of the controller. There is some weird bug with circleci where it sometimes cannot download kustomize during tests 😠.

@Demonsthere Demonsthere merged commit b401e2a into ory:master Aug 15, 2023
12 checks passed
@Jorgagu Jorgagu deleted the feat/add-hydra-client-jwks-uri branch August 15, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants