Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: to correctly configure BASE_PATH for selfservice-ui chart #652

Merged

Conversation

emmenko
Copy link
Contributor

@emmenko emmenko commented Nov 9, 2023

Related Issue or Design Document

Fixes #651

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@CLAassistant
Copy link

CLAassistant commented Nov 9, 2023

CLA assistant check
All committers have signed the CLA.

@emmenko emmenko changed the title fix(kratos-selfservice-ui): to correctly configure BASE_PATH fix: to correctly configure BASE_PATH for selfservice-ui chart Nov 9, 2023
Copy link
Collaborator

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update values in hacks/values so the CI can test this option :)

@emmenko
Copy link
Contributor Author

emmenko commented Nov 13, 2023

Please also update values in hacks/values so the CI can test this option :)

Hi @Demonsthere , I'm not sure I understand what to update in hacks/values. Could you point me to the correct spot? I don't see any reference to baseUrl over there 🤔

Thanks

@Demonsthere
Copy link
Collaborator

The values in hacks are override we manage and use to test the ci (basically do helm install/upgrade -f overrides.yaml) I thought about setting some non default basePath in that values so that we can see if the override values propagates properly within the chart. In this case we can probably just set it to localhost :)

Copy link
Collaborator

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, now we see that some tests needed to be changes as well :d
Thanks!

@Demonsthere Demonsthere merged commit 7fb19cd into ory:master Nov 14, 2023
11 checks passed
@emmenko
Copy link
Contributor Author

emmenko commented Nov 14, 2023

Yep, thanks for the help! 🙌

@emmenko emmenko deleted the nm-fix-kratos-selfservice-ui-base-path branch November 14, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kratos selfservice UI incorrectly supports BASE_PATH
3 participants