fix: disable monitoring.coreos.com/v1 api check #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fleblay
changed the title
Demonsthere
requested changes
Nov 27, 2023
Demonsthere
approved these changes
Nov 28, 2023
| @@ -7,4 +7,4 @@ cd "$( dirname "${BASH_SOURCE[0]}" )/.." | |||
| schema_url="https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/" | |||
| k8s_version="1.27.2" | |||
|
|
|||
| helm kubeconform "./helm/charts/${1}" --strict --schema-location "${schema_url}" -f "hacks/values/${1}.yaml" --kubernetes-version "${k8s_version}" --summary --verbose | |||
| helm kubeconform "./helm/charts/${1}" --strict --schema-location "${schema_url}" --schema-location ./hacks/servicemonitor_v1.json -f "hacks/values/${1}.yaml" --kubernetes-version "${k8s_version}" --summary --verbose | |||
There was a problem hiding this comment.
I think this could be improved, but this is something to be done in a separate issue :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
.Capabilities.APIVersions.Has "monitoring.coreos.com/v1"check done before enabling the service monitoras this test will always fail
To avoid breaking changes, the default value for
.Values.serviceMonitor.enabledis set to false.Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
Further comments