Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add template value for kratos metric path #654

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

fleblay
Copy link
Contributor

@fleblay fleblay commented Nov 27, 2023

Add possibility to customize kratos endpoint path for prometheus (the same way it is possible to do so in HYDRA)

Related Issue or Design Document

Checklist

  • [ x] I have read the contributing guidelines and signed the CLA.
  • [ x] I have referenced an issue containing the design document if my change introduces a new feature.
  • [ x] I have read the security policy.
  • [ x] I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • [ x] I have added tests that prove my fix is effective or that my feature works.
  • [ x] I have added the necessary documentation within the code base (if appropriate).

Further comments

@fleblay fleblay changed the title [SERVICE-MONITOR] Add template value for kratos metric path [FEAT] Add template value for kratos metric path Nov 27, 2023
@fleblay fleblay changed the title [FEAT] Add template value for kratos metric path feat: Add template value for kratos metric path Nov 27, 2023
@fleblay fleblay changed the title feat: Add template value for kratos metric path feat: add template value for kratos metric path Nov 27, 2023
Copy link
Collaborator

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the values in hacks/values to override the default, we want the CI to test if the overloaded config generates a valid manifest

@Demonsthere
Copy link
Collaborator

LGTM :)

@Demonsthere Demonsthere merged commit 831cdf2 into ory:master Nov 28, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants