Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: secrets typo #672

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix: secrets typo #672

merged 1 commit into from
Apr 17, 2024

Conversation

afreakk
Copy link
Contributor

@afreakk afreakk commented Apr 12, 2024

This typo cost me a bit of time, I was sure secret_s_.enabled was true, but I had an s to much.

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@afreakk afreakk changed the title fix: typo fix: secrets typo Apr 12, 2024
Copy link
Collaborator

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, my bad for not spotting that 😅 Thanks!

@Demonsthere Demonsthere merged commit 1c1702a into ory:master Apr 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants