Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow dsn to be configured optionally #678

Merged
merged 11 commits into from
May 15, 2024

Conversation

dlahn
Copy link
Contributor

@dlahn dlahn commented May 13, 2024

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@dlahn dlahn mentioned this pull request May 13, 2024
6 tasks
Copy link
Collaborator

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! :)
Can we add one test case for that? In the hacks/values directory we have the values.yaml that are used in our CI. I'd like this optional DSN option to be enabled for one one of the charts (so loaded from an external secret, the secret can be stored and loaded from here https://github.com/ory/k8s/tree/master/hacks/manifests)

@Demonsthere
Copy link
Collaborator

I think we fall into helm/helm#12438 here 😞 We can try with the --force option for upgrade, but if we fall into it, all users will :/

@dlahn dlahn requested a review from Demonsthere May 14, 2024 16:53
@dlahn
Copy link
Contributor Author

dlahn commented May 14, 2024

@Demonsthere Thanks for all of the help with the tests. It looks like it is all working now, and it matches how Hydra handles this.

Copy link
Collaborator

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!
Great job with the pr :) I would have a minot nitpick before we merge this: since now we see in the values for kratos what exactly needs to be modified to allow sideloading dsn, could you update the docs to show that? We could also link in the docs to the values files for kratos for a real life example!

Copy link
Collaborator

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating docs :)

hacks/values/kratos.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Demonsthere Demonsthere merged commit 26bf845 into ory:master May 15, 2024
14 checks passed
@Dennor Dennor mentioned this pull request May 15, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants