chore: format using Make #1022
Merged
chore: format using Make #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zepatrik
requested changes
Sep 20, 2022
| @@ -8,8 +8,6 @@ | |||
| }, | |||
| "scripts": { | |||
| "doctoc": "doctoc README.md", | |||
| "format": "prettier --write .", | |||
There was a problem hiding this comment.
There is a bunch of CI scripts that rely on these to be present, I quickly found at least
https://github.com/ory/ci/blob/efcf157174048909dacafa29463f95aba629e37c/src/scripts/changelog/generate.sh#L52
We have to ensure this is not required anymore by any automation.
There was a problem hiding this comment.
Great catch! I'll fix those as part of these PRs.
.github/workflows/format.yml
Outdated
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-go@v3 | ||
| with: | ||
| go-version: 1.18 |
There was a problem hiding this comment.
Good to know, thanks! I'm updating all codebases to Go 1.19 and see what breaks.
|
@zepatrik all comments addressed PTAL |
zepatrik
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses parts of https://github.com/ory-corp/general/issues/735.
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.