Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roles and policies filter #124

Merged
merged 23 commits into from
Aug 21, 2019
Merged

Roles and policies filter #124

merged 23 commits into from
Aug 21, 2019

Conversation

sum2000
Copy link
Contributor

@sum2000 sum2000 commented Jul 20, 2019

Related issue

#121 #20

Proposed changes

Added support for filtering roles and policies as discussed with @aeneasr.

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

Further comments

I messed up history rewrite in my original PR, resubmitting this one

@sum2000 sum2000 mentioned this pull request Jul 20, 2019
storage/manager.go Outdated Show resolved Hide resolved
engine/ladon/handler.go Outdated Show resolved Hide resolved
engine/ladon/handler.go Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Jul 28, 2019

CLA assistant check
All committers have signed the CLA.

@aeneasr
Copy link
Member

aeneasr commented Jul 29, 2019

Let me know when this is good for 👁 :)

@sum2000
Copy link
Contributor Author

sum2000 commented Jul 31, 2019

Swamped at work, will probably finish this tomorrow.

@sum2000 sum2000 changed the title Feature/list role by member Raole and policies filter Aug 5, 2019
@sum2000 sum2000 changed the title Raole and policies filter Roles and policies filter Aug 5, 2019
engine/ladon/doc.go Outdated Show resolved Hide resolved
storage/handler.go Outdated Show resolved Hide resolved
@sum2000
Copy link
Contributor Author

sum2000 commented Aug 5, 2019

Good to review apart from the comments I mentioned

@sum2000
Copy link
Contributor Author

sum2000 commented Aug 6, 2019

@aeneasr

@aeneasr
Copy link
Member

aeneasr commented Aug 8, 2019

Sorry I completely dropped the ball on this one! Reviewing now

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks super solid! Only a few minor things left, and also, could you please add a test in the handler? :)

https://github.com/ory/keto/blob/master/engine/ladon/handler_test.go

engine/ladon/doc.go Outdated Show resolved Hide resolved
storage/policy.go Outdated Show resolved Hide resolved
docs/api.swagger.json Outdated Show resolved Hide resolved
@aeneasr
Copy link
Member

aeneasr commented Aug 9, 2019

I'm not sure what the problem is - maybe I misunderstood it - but it seems that the member parameter is propagated properly in the SDK? Maybe you could lay out the problem again in one comment, I think I must have missed something.

@sum2000
Copy link
Contributor Author

sum2000 commented Aug 20, 2019

@aeneasr ready for review again. A note on the filter method, if someone passing regex query in the filter params then they are treated as exact. This can be changed in future PR. Let's try to close this soon.

@aeneasr
Copy link
Member

aeneasr commented Aug 21, 2019

Awesome - thank you for your patience and hard work, you rock! :)

@aeneasr aeneasr merged commit db94481 into ory:master Aug 21, 2019
@sum2000
Copy link
Contributor Author

sum2000 commented Aug 21, 2019

@aeneasr My pleasure, many more PRs to come! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants