Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cors config values are ignored #789

Merged
merged 3 commits into from
Dec 1, 2021
Merged

fix: Cors config values are ignored #789

merged 3 commits into from
Dec 1, 2021

Conversation

vancanhuit
Copy link
Contributor

@vancanhuit vancanhuit commented Nov 30, 2021

Related issue(s)

closes #788

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the changes look good. The CI failure seems unrelated. I will fix it separately and then merge this once ✔️

@zepatrik zepatrik merged commit ffeb5e3 into ory:master Dec 1, 2021
Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks again, I added a small test and fixed the config provider accordingly, as I was on it already.

@vancanhuit vancanhuit deleted the fix/cors-values-ignored branch December 2, 2021 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CORS config values are ignored
2 participants