Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return error if invalid UUID is supplied to ids filter #4116

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

jonas-jonas
Copy link
Member

@jonas-jonas jonas-jonas commented Sep 23, 2024

We currently return a 500 error if the UUID supplied to the ids parameter of the identity list endpoint:

{
	"error": {
		"code": 500,
		"status": "Internal Server Error",
		"request": "fab8e637-d424-90c1-a766-9d71f157b3d8",
		"message": "unable to fetch records: ERROR: error in argument for $3: could not parse \"asd\" as type uuid: could not parse \"asd\" as type uuid: uuid: incorrect UUID length: asd (SQLSTATE 22P02)"
	}
}

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Copy link
Contributor

@hperl hperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.65%. Comparing base (340f698) to head (5762b21).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4116      +/-   ##
==========================================
+ Coverage   78.63%   78.65%   +0.02%     
==========================================
  Files         377      377              
  Lines       26942    26946       +4     
==========================================
+ Hits        21185    21194       +9     
+ Misses       4146     4142       -4     
+ Partials     1611     1610       -1     
Flag Coverage Δ
78.65% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonas-jonas jonas-jonas merged commit 98140f2 into master Sep 25, 2024
32 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/parseIdsInIdentityListing branch September 25, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants