Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: small improvements to discord oidc provider guide #783

Merged

Conversation

NickUfer
Copy link
Contributor

Proposed changes

  • Adds reference to where the claims struct is built
  • Removes statement that iss claim is added by email scope. It is only be added by the identify scope
  • Makes it more clear that the email scope is an addition to the identify scope. email does not work / has no function without identify

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@aeneasr aeneasr merged commit 6a3c453 into ory:master Oct 22, 2020
@aeneasr
Copy link
Member

aeneasr commented Oct 22, 2020

Awesome 🎉 Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants