Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: export remaining manager test helpers #73

Merged
merged 1 commit into from
Jun 13, 2017
Merged

all: export remaining manager test helpers #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
181 changes: 3 additions & 178 deletions manager_all_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,136 +13,8 @@ import (
. "github.com/ory/ladon"
. "github.com/ory/ladon/manager/memory"
. "github.com/ory/ladon/manager/sql"
"github.com/pborman/uuid"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)

var managerPolicies = []*DefaultPolicy{
{
ID: uuid.New(),
Description: "description",
Subjects: []string{"user", "anonymous"},
Effect: AllowAccess,
Resources: []string{"article", "user"},
Actions: []string{"create", "update"},
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{},
Effect: AllowAccess,
Resources: []string{"<article|user>"},
Actions: []string{"view"},
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{},
Effect: AllowAccess,
Resources: []string{},
Actions: []string{"view"},
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{},
Effect: AllowAccess,
Resources: []string{},
Actions: []string{},
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{},
Effect: AllowAccess,
Resources: []string{"foo"},
Actions: []string{},
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{"foo"},
Effect: AllowAccess,
Resources: []string{"foo"},
Actions: []string{},
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{"foo"},
Effect: AllowAccess,
Resources: []string{},
Actions: []string{},
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Effect: AllowAccess,
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{"<peter|max>"},
Effect: DenyAccess,
Resources: []string{"article", "user"},
Actions: []string{"view"},
Conditions: Conditions{
"owner": &EqualsSubjectCondition{},
},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{"<user|max|anonymous>", "peter"},
Effect: DenyAccess,
Resources: []string{".*"},
Actions: []string{"disable"},
Conditions: Conditions{
"ip": &CIDRCondition{
CIDR: "1234",
},
"owner": &EqualsSubjectCondition{},
},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{"<.*>"},
Effect: AllowAccess,
Resources: []string{"<article|user>"},
Actions: []string{"view"},
Conditions: Conditions{
"ip": &CIDRCondition{
CIDR: "1234",
},
"owner": &EqualsSubjectCondition{},
},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{"<us[er]+>"},
Effect: AllowAccess,
Resources: []string{"<article|user>"},
Actions: []string{"view"},
Conditions: Conditions{
"ip": &CIDRCondition{
CIDR: "1234",
},
"owner": &EqualsSubjectCondition{},
},
},
}

var managers = map[string]Manager{}
var migrators = map[string]ManagerMigrator{}

Expand Down Expand Up @@ -195,60 +67,13 @@ func connectMySQL(wg *sync.WaitGroup) {
}

func TestGetErrors(t *testing.T) {
for _, s := range managers {
_, err := s.Get(uuid.New())
assert.Error(t, err)

_, err = s.Get("asdf")
assert.Error(t, err)
for k, s := range managers {
t.Run("manager=" + k, TestHelperGetErrors(s))
}
}

func TestCreateGetDelete(t *testing.T) {
for k, s := range managers {
t.Run(fmt.Sprintf("manager=%s", k), func(t *testing.T) {
for i, c := range managerPolicies {
t.Run(fmt.Sprintf("case=%d/id=%s/type=create", i, c.GetID()), func(t *testing.T) {
_, err := s.Get(c.GetID())
require.Error(t, err)
require.NoError(t, s.Create(c))
})

t.Run(fmt.Sprintf("case=%d/id=%s/type=query", i, c.GetID()), func(t *testing.T) {
get, err := s.Get(c.GetID())
require.NoError(t, err)

AssertPolicyEqual(t, c, get)
})
}

t.Run("type=query-all", func(t *testing.T) {
pols, err := s.GetAll(100, 0)
require.NoError(t, err)
assert.Len(t, pols, len(managerPolicies))

found := map[string]int{}
for _, got := range pols {
for _, expect := range managerPolicies {
if got.GetID() == expect.GetID() {
found[got.GetID()]++
}
}
}

for _, f := range found {
assert.Equal(t, 1, f)
}
})

for i, c := range managerPolicies {
t.Run(fmt.Sprintf("case=%d/id=%s/type=delete", i, c.GetID()), func(t *testing.T) {
assert.NoError(t, s.Delete(c.ID))

_, err := s.Get(c.GetID())
assert.Error(t, err)
})
}
})
t.Run(fmt.Sprintf("manager=%s", k), TestHelperCreateGetDelete(s))
}
}
184 changes: 184 additions & 0 deletions manager_test_helper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,131 @@ import (
"github.com/stretchr/testify/require"
)

var TestManagerPolicies = []*DefaultPolicy{
{
ID: uuid.New(),
Description: "description",
Subjects: []string{"user", "anonymous"},
Effect: AllowAccess,
Resources: []string{"article", "user"},
Actions: []string{"create", "update"},
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{},
Effect: AllowAccess,
Resources: []string{"<article|user>"},
Actions: []string{"view"},
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{},
Effect: AllowAccess,
Resources: []string{},
Actions: []string{"view"},
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{},
Effect: AllowAccess,
Resources: []string{},
Actions: []string{},
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{},
Effect: AllowAccess,
Resources: []string{"foo"},
Actions: []string{},
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{"foo"},
Effect: AllowAccess,
Resources: []string{"foo"},
Actions: []string{},
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{"foo"},
Effect: AllowAccess,
Resources: []string{},
Actions: []string{},
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Effect: AllowAccess,
Conditions: Conditions{},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{"<peter|max>"},
Effect: DenyAccess,
Resources: []string{"article", "user"},
Actions: []string{"view"},
Conditions: Conditions{
"owner": &EqualsSubjectCondition{},
},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{"<user|max|anonymous>", "peter"},
Effect: DenyAccess,
Resources: []string{".*"},
Actions: []string{"disable"},
Conditions: Conditions{
"ip": &CIDRCondition{
CIDR: "1234",
},
"owner": &EqualsSubjectCondition{},
},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{"<.*>"},
Effect: AllowAccess,
Resources: []string{"<article|user>"},
Actions: []string{"view"},
Conditions: Conditions{
"ip": &CIDRCondition{
CIDR: "1234",
},
"owner": &EqualsSubjectCondition{},
},
},
{
ID: uuid.New(),
Description: "description",
Subjects: []string{"<us[er]+>"},
Effect: AllowAccess,
Resources: []string{"<article|user>"},
Actions: []string{"view"},
Conditions: Conditions{
"ip": &CIDRCondition{
CIDR: "1234",
},
"owner": &EqualsSubjectCondition{},
},
},
}

var testPolicies = []*DefaultPolicy{
{
ID: uuid.New(),
Expand Down Expand Up @@ -150,3 +275,62 @@ func testEq(a, b []string) error {

return nil
}

func TestHelperGetErrors(s Manager) func (t *testing.T) {
return func (t *testing.T) {
_, err := s.Get(uuid.New())
assert.Error(t, err)

_, err = s.Get("asdf")
assert.Error(t, err)
}
}

func TestHelperCreateGetDelete(s Manager) func (t *testing.T) {
return func (t *testing.T) {

for i, c := range TestManagerPolicies {
t.Run(fmt.Sprintf("case=%d/id=%s/type=create", i, c.GetID()), func(t *testing.T) {
_, err := s.Get(c.GetID())
require.Error(t, err)
require.NoError(t, s.Create(c))
})

t.Run(fmt.Sprintf("case=%d/id=%s/type=query", i, c.GetID()), func(t *testing.T) {
get, err := s.Get(c.GetID())
require.NoError(t, err)

AssertPolicyEqual(t, c, get)
})
}

t.Run("type=query-all", func(t *testing.T) {
pols, err := s.GetAll(100, 0)
require.NoError(t, err)
assert.Len(t, pols, len(TestManagerPolicies))

found := map[string]int{}
for _, got := range pols {
for _, expect := range TestManagerPolicies {
if got.GetID() == expect.GetID() {
found[got.GetID()]++
}
}
}

for _, f := range found {
assert.Equal(t, 1, f)
}
})

for i, c := range TestManagerPolicies {
t.Run(fmt.Sprintf("case=%d/id=%s/type=delete", i, c.GetID()), func(t *testing.T) {
assert.NoError(t, s.Delete(c.ID))

_, err := s.Get(c.GetID())
assert.Error(t, err)
})
}

}
}
Loading