Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make subject configurable using go template #129

Merged
merged 2 commits into from
Oct 23, 2018

Conversation

lsjostro
Copy link
Contributor

@lsjostro lsjostro commented Oct 22, 2018

Related issue

#128

Proposed changes

Checklist

  • I have read the contributing guidelines
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact hi@ory.sh) from the maintainers to push the changes.
  • I signed the Developer's Certificate of Origin
    by signing my commit(s). You can amend your signature to the most recent commit by using git commit --amend -s. If you
    amend the commit, you might need to force push using git push --force HEAD:<branch>. Please be very careful when using
    force push.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

Further comments

Signed-off-by: Lars Sjöström <lars@radicore.se>
@aeneasr
Copy link
Member

aeneasr commented Oct 22, 2018

This looks very good and can be merged as is. Could you please update the keto_warden section to reflect this change/enhancement?

Signed-off-by: Lars Sjöström <lars@radicore.se>
@aeneasr
Copy link
Member

aeneasr commented Oct 23, 2018

Thanks!

@aeneasr aeneasr merged commit ee9dcdd into ory:master Oct 23, 2018
@lsjostro
Copy link
Contributor Author

Thank you! 😄

@lsjostro lsjostro deleted the parse-subject branch October 23, 2018 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants