-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(dart): add link to source code / repository for pub.dev #270
Conversation
@jonas-jonas this also allows users to update to dio v5.0.0 fixing two vulnerabilities https://github.com/advisories?query=type%3Areviewed+ecosystem%3Apub+dio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, this looks good from my POV.
Not sure if this might have to do something with my M1 MacBook?!
The Dart executable segfaults for me too, which is likely due to the amd64 emulation going on. I rented a Linux VM to check the changes.
Should the dio
bump to ^5.0.0
be considered a breaking change?
❓ Breaking change or not:
I'm not sure but I guess the Ory SDK would find the latest version of Ory that uses Dio 4.x. Otherwise we'd have package users required to update their packages all to the latest versions which they anyways should do to ensure the best compatibility. |
I've actually figured out that I can run open-api-generator in the Docker container and then run |
Ah, good idea.
Is that not the case? The generated version constraint looks like it requires >5. |
The current Ory SDKs require dio version With the change, the Ory SDKs would require dio version So the only change that could make it a breaking change would be because the Ory SDKs now depend on dio version 5.x.x. According to the server FAQ it should probably not be considered a breaking change: |
@IchordeDionysos thank you! |
Related Issue or Design Document
Follow up of #263
Adds the repository to the pubspec.yaml so that on pub.dev a link to the repository will be shown to users.
https://dart.dev/tools/pub/pubspec#repository
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
Further comments
I, unfortunately, couldn't test it locally as I get errors for both the current Docker image v0.51.0 as well as a locally built image ...
Not sure if this might have to do something with my M1 MacBook?!