Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB traces report EOF errors #97

Closed
jtescher opened this issue Dec 3, 2019 · 2 comments · Fixed by #98
Closed

DB traces report EOF errors #97

jtescher opened this issue Dec 3, 2019 · 2 comments · Fixed by #98

Comments

@jtescher
Copy link
Contributor

jtescher commented Dec 3, 2019

Describe the bug

Currently EOF errors show up in DB traces.

To Reproduce

Steps to reproduce the behavior:

Enable tracing, view db traces, you will see a lot of:
image

Expected behavior

EOF should not be an opentracing error.

Solution

The fix is likely to update https://github.com/luna-duclos/instrumentedsql to the latest release which has this fixed.

See luna-duclos/instrumentedsql#23 for more information.

@aeneasr
Copy link
Member

aeneasr commented Dec 3, 2019

Nice, would you update to go.mod files accordingly in a PR? :)

@jtescher
Copy link
Contributor Author

jtescher commented Dec 4, 2019

@aeneasr done!

aeneasr pushed a commit that referenced this issue Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants