Only retry requests on certain status codes #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't make sense to retry e.g. 404s, or other codes that would tend to indicate a user error or permanent problem rather than some transient issue. This is my best cut at a list of 'appropriate' codes to retry on, based on the obvious canonical source, http.cat. Signed-off-by: Adam Williamson <awilliam@redhat.com>
|
This sort of addresses #16 in an oblique way. |
|
welp, I think this one makes sense, so I'm gonna merge it. :D |
|
Thanks! |
baierjan
added a commit
to openSUSE/qem-bot
that referenced
this pull request
Mar 3, 2023
This reverts commit f41b070. We should be able to use retry again as openQA-python-client will not retry for 404 anymore. References: * https://progress.opensuse.org/issues/107923#note-35 * os-autoinst/openQA-python-client#34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make sense to retry e.g. 404s, or other codes that would tend to indicate a user error or permanent problem rather than some transient issue. This is my best cut at a list of 'appropriate' codes to retry on, based on the obvious canonical source, http.cat.
Signed-off-by: Adam Williamson awilliam@redhat.com