Skip to content

Run CI for Python 3.6 on Ubuntu 20.04 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2022

Conversation

kalikiana
Copy link
Member

@kalikiana kalikiana commented Dec 2, 2022

The now latest Ubuntu no longer ships with 3.6.

This is a partial revert of #38.

@kalikiana kalikiana changed the title Run CI for Python tests on Ubuntu 20.04 Run CI for Python tests >=3.6 on Ubuntu 20.04 Dec 2, 2022
@kalikiana kalikiana marked this pull request as ready for review December 2, 2022 15:46
@AdamWill
Copy link
Contributor

AdamWill commented Dec 2, 2022

So I'm not sure I like this, I don't like pinning things on older versions. I think if we really want Python 3.6 testing we might want to do the thing where it's a separate workflow and all the other tests run on ubuntu-latest.

Can you rebase this on #39 and see if stable 3.11 and alpha 3.12 work on 20.04? If those don't work, I'd consider that worse than losing 3.6...

@kalikiana
Copy link
Member Author

No strong opinion. I just wanted to address #38 (comment) and that was the easier option out of the two you suggested 😉
Will give it a try.

@AdamWill
Copy link
Contributor

AdamWill commented Dec 2, 2022

You need to add 3.6 back to the python-version: list in tox.yml to get 3.6 tests actually running again on github.

The now latest Ubuntu no longer ships with 3.6.
@AdamWill
Copy link
Contributor

AdamWill commented Dec 2, 2022

OK, well, at least all versions work there. The above is just my personal opinion, if everyone else likes this more we can go with it...what does everyone else think? @okurz @mimi1vx @perlpunk

@kalikiana
Copy link
Member Author

OK, well, at least all versions work there. The above is just my personal opinion, if everyone else likes this more we can go with it...

You suggested two ways. I demonstrated both work. Right now it's using a different image for 3.6.

@kalikiana kalikiana changed the title Run CI for Python tests >=3.6 on Ubuntu 20.04 Run CI for Python on Ubuntu 20.04 Dec 2, 2022
Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this way better because it's explicit that we only need the older ubuntu-20.04 for python 3.6

@AdamWill
Copy link
Contributor

AdamWill commented Dec 2, 2022

Oh sorry, I didn't notice you'd switched it! That matrix.os thing is neat, nice job. I like it this way, let's see if others have opinions.

@kalikiana kalikiana changed the title Run CI for Python on Ubuntu 20.04 Run CI for Python 3.6 on Ubuntu 20.04 Dec 2, 2022
@jvanasco
Copy link

jvanasco commented Dec 2, 2022

Thanks for sharing this in /actions/setup-python/issues/543, @AdamWill !

Thank you SO MUCH for devising this solution, @kalikiana ! This is the exact approach I needed to implement in several projects. You've really helped a lot of people today!

@AdamWill AdamWill merged commit fccd875 into os-autoinst:main Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants