-
Notifications
You must be signed in to change notification settings - Fork 20
Run CI for Python 3.6 on Ubuntu 20.04 #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8052ae7
to
a9fa800
Compare
So I'm not sure I like this, I don't like pinning things on older versions. I think if we really want Python 3.6 testing we might want to do the thing where it's a separate workflow and all the other tests run on ubuntu-latest. Can you rebase this on #39 and see if stable 3.11 and alpha 3.12 work on 20.04? If those don't work, I'd consider that worse than losing 3.6... |
No strong opinion. I just wanted to address #38 (comment) and that was the easier option out of the two you suggested 😉 |
a9fa800
to
16006fe
Compare
You need to add 3.6 back to the |
The now latest Ubuntu no longer ships with 3.6.
16006fe
to
807361e
Compare
You suggested two ways. I demonstrated both work. Right now it's using a different image for 3.6. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this way better because it's explicit that we only need the older ubuntu-20.04 for python 3.6
Oh sorry, I didn't notice you'd switched it! That |
Thanks for sharing this in /actions/setup-python/issues/543, @AdamWill ! Thank you SO MUCH for devising this solution, @kalikiana ! This is the exact approach I needed to implement in several projects. You've really helped a lot of people today! |
The now latest Ubuntu no longer ships with 3.6.
This is a partial revert of #38.