Skip to content

Conversation

kalikiana
Copy link
Member

@okurz
Copy link
Member

okurz commented Jul 15, 2025

@kalikiana @Martchus is this still needed? I don't see a good justification, just "adjust". So … is this a fix, correction, improvement?

Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both changes make sense and that's also what we have in similar units. (I've just checked all timers and their service files in the openQA repo.)


[Install]
WantedBy=default.target
WantedBy=timers.target
Copy link
Contributor

@Martchus Martchus Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense according to https://man.archlinux.org/man/systemd.special.7. We also use this in other timer-triggered units in openQA.

User=geekotest

[Install]
WantedBy=default.target
Copy link
Contributor

@Martchus Martchus Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means one can no longer enable this unit normally, e.g. to run the triggering just once after boot. I guess this makes sense for this timer-triggered unit. We also don't have this for other timer-triggered units in openQA.

@kalikiana
Copy link
Member Author

@kalikiana @Martchus is this still needed? I don't see a good justification, just "adjust". So … is this a fix, correction, improvement?

This refers to a comment on #268 after merging. Somehow the follow-up got lost, so thank you for catching that!

@kalikiana kalikiana force-pushed the systemd_timer_service2 branch from 6c1242a to 54bbcd7 Compare July 15, 2025 10:52
@Martchus Martchus merged commit bb92b87 into os-autoinst:master Jul 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants