-
Notifications
You must be signed in to change notification settings - Fork 41
Adjust install targets of systemd service and timer #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kalikiana @Martchus is this still needed? I don't see a good justification, just "adjust". So … is this a fix, correction, improvement? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think both changes make sense and that's also what we have in similar units. (I've just checked all timers and their service files in the openQA repo.)
|
||
[Install] | ||
WantedBy=default.target | ||
WantedBy=timers.target |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense according to https://man.archlinux.org/man/systemd.special.7. We also use this in other timer-triggered units in openQA.
User=geekotest | ||
|
||
[Install] | ||
WantedBy=default.target |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means one can no longer enable this unit normally, e.g. to run the triggering just once after boot. I guess this makes sense for this timer-triggered unit. We also don't have this for other timer-triggered units in openQA.
This refers to a comment on #268 after merging. Somehow the follow-up got lost, so thank you for catching that! |
6c1242a
to
54bbcd7
Compare
See: https://progress.opensuse.org/issues/166433