Provide user-virtio-terminal console option #14967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files |
b10n1k
force-pushed
the
enable_virtio-terminal
branch
from
c6e9ebf
to
8e824fe
Compare
kalikiana
reviewed
May 30, 2022
kalikiana
reviewed
May 30, 2022
b10n1k
force-pushed
the
enable_virtio-terminal
branch
from
8e824fe
to
838b650
Compare
b10n1k
commented
May 30, 2022
mdoucha
approved these changes
May 30, 2022
The `select_serial_terminal` picks by default `root-virtio-terminal` but the subroutine provides parameter to select a console as normal user. Somehow this found misconfigured. The condition was like that `$console = $root ? 'root-virtio-terminal' : 'virtio-terminal';`. There was two main issues. One was that the propor console was not added during the `init_consoles` and the second was that the variable was not a valid option. The first is solved easily by adding another line to call `add_console`. In the second case the correct name is `user-virtio-terminal` instead `virtio-terminal`. the underline variable is evaluated later against a regex to assign some other variables, one of them is *$user* and another is *type* which each are required for the user _login_ and the console _initialization_. Signed-off-by: Ioannis Bonatakis <ybonatakis@suse.com>
b10n1k
force-pushed
the
enable_virtio-terminal
branch
from
838b650
to
33fda7f
Compare
kalikiana
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
select_serial_terminalpicks by defaultroot-virtio-terminalbut thesubroutine provides parameter to select a console as normal user.
Somehow this found misconfigured. The condition was like that
$console = $root ? 'root-virtio-terminal' : 'virtio-terminal';. There wastwo main issues. One was that the propor console was not added during the
init_consolesand the second was that the variable was not a valid option.The first is solved easily by adding another line to call
add_console.In the second case the correct name is
user-virtio-terminalinsteadvirtio-terminal. the underline variable is evaluated later against a regexto assign some other variables, one of them is $user and another is type
which each are required for the user login and the console initialization.
Signed-off-by: Ioannis Bonatakis ybonatakis@suse.com