[WIP] Split out the setup of the serial device to reduce the need to schedule consoletest_setup #4909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
changed the title
|
Looks a good idea! |
|
@okurz Wasn't something similar done recently? |
…le consoletest_setup "consoletest_setup" is a bit of a mixed case: It conducts some steps necessary for "console" tests but also some of the other test modules that just use the console or even just an xterm window. This commit splits out the setup of the serial device which is most likely the most important step so that this step can be scheduled in more test suite flows where it is needed but consoletest_setup would be too big. See os-autoinst#4900 as a motivation to do this.
okurz
force-pushed
the
enhance/serialdev
branch
from
941a1b0
to
7ded559
Compare
|
can't maintain that currently |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"consoletest_setup" is a bit of a mixed case: It conducts some steps necessary
for "console" tests but also some of the other test modules that just use the
console or even just an xterm window. This commit splits out the setup of the
serial device which is most likely the most important step so that this step
can be scheduled in more test suite flows where it is needed but
consoletest_setup would be too big.
See #4900
as a motivation to do this.