Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change VERSION for migration group specific flavor #7624

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

coolgw
Copy link
Contributor

@coolgw coolgw commented Jun 6, 2019

For 12sp5 project, we introduce new migration automation scenario 12sp5->15sp1, so some specific change will happen.
We create new flavor Migration-from-SLE12-SP5-to-SLE15-SPx for this kind of test cases, and triggered by VERSION=12-SP5 FlAVOR=Migration-from-SLE12-SP5-to-SLE15-SPx together with other 12sp5 migration test group. And we will have 12sp5 group view on openqa UI once NB is trigger
BUT we need change VERSION to 15-SP1 since only this can let migration code handle correctly to upgrade to 15SP1 in stead of 12-SP5.
This flavor will only using by migration group and will not impact any other group, once 12sp5 project finish, we can delete this special setting.
Welcome any comments.

lib/main_common.pm Show resolved Hide resolved
@asmorodskyi
Copy link
Member

I also not like what this patch is doing , but take into account that it influences only specific flavor used by patch's author and the fact that actually I can not suggests anything better because have low expertise in the subject I will merge it.
@okurz same logic I am applying to your comment as well ...

@asmorodskyi asmorodskyi merged commit 8b5f329 into os-autoinst:master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants