Symfony 6.3 and API Platform 2.7 #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimi-itk
changed the base branch from
develop
to
feature/DISPLAY-1007-cleanup-draft-without-entity-changes
tuj
requested changes
Nov 8, 2023
| - "traefik.http.routers.${COMPOSE_PROJECT_NAME}Mailhog.rule=Host(`mailhog-${COMPOSE_DOMAIN}`)" | ||
| - "traefik.http.services.${COMPOSE_PROJECT_NAME}Mailhog.loadbalancer.server.port=8025" | ||
| - "traefik.http.routers.${COMPOSE_PROJECT_NAME}mail.rule=Host(`mail-${COMPOSE_DOMAIN}`)" | ||
| - "traefik.http.services.${COMPOSE_PROJECT_NAME}mail.loadbalancer.server.port=8025" | ||
|
|
||
| redis: |
There was a problem hiding this comment.
Should we move redis and node to docker-compose.override.yml ?
There was a problem hiding this comment.
That would be the ITK Dev way to do it, but 04cbc36
| @@ -0,0 +1,39 @@ | |||
| <?php | |||
There was a problem hiding this comment.
This seems like it should be removed.
Why was it added?
There was a problem hiding this comment.
It was added in 30ca376 to make our “Validate Doctrine Schema” stop complaining. It sure is weird …
There was a problem hiding this comment.
A comment on this weird stuff added in d453c11
| @@ -67,6 +59,7 @@ public function normalize($object, $format = null, array $context = []): array|s | |||
| $data = ['@context' => '/contexts/'.$context['output']['name']]; | |||
|
|
|||
| if (isset($context['operation_type']) && OperationType::SUBRESOURCE === $context['operation_type']) { | |||
| // FIXME: When do we end up here? `getSubresourceIriFromResourceClass` is not defined anymore. | |||
| { | ||
| return true; | ||
| // FIXME: Figure out what to actually return here? |
…raft-without-entity-changes' into feature/DISPLAY-1030-symfony-update
rimi-itk
changed the base branch from
feature/DISPLAY-1007-cleanup-draft-without-entity-changes
to
develop
tuj
approved these changes
Nov 9, 2023
turegjorup
added a commit
to aroskanalen/display-api-service
that referenced
this pull request
Feb 6, 2024
…elations modified
turegjorup
added a commit
to aroskanalen/display-api-service
that referenced
this pull request
Feb 6, 2024
turegjorup
added a commit
to aroskanalen/display-api-service
that referenced
this pull request
Feb 6, 2024
turegjorup
added a commit
to aroskanalen/display-api-service
that referenced
this pull request
Feb 8, 2024
turegjorup
added a commit
to aroskanalen/display-api-service
that referenced
this pull request
Feb 8, 2024
…ns modified listener
turegjorup
added a commit
to aroskanalen/display-api-service
that referenced
this pull request
Feb 8, 2024
tuj
added a commit
that referenced
this pull request
Feb 23, 2024
…odified_bug #165: Bugfix for "relations modified" not set correctly on OneToMany relations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://jira.itkdev.dk/browse/DISPLAY-1030
Description
Updates to Symfony 6.3 and API Platform 2.7 (cf. https://api-platform.com/docs/core/upgrade-guide/#im-migrating-from-26-and-want-to-prepare-for-30)
Checklist
The API Specification has some (hopefully) insignificant changes:
linksare not set in response examples (do we use these links?) This is related to the line https://github.com/api-platform/core/blob/v2.6.8/src/OpenApi/Factory/OpenApiFactory.php#L188 (and others) having been removed and refactored extensively.examplesand additional properties added inschemahttps://gist.github.com/rimi-itk/ff2c9400aa8d6d76caae698053b54638#file-compare-api-specs-sh has been used to test the API spec piece by piece and compare it with https://github.com/os2display/display-api-service/tree/develop