API Platform 3 #173
Merged
API Platform 3 #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…latform-3 # Conflicts: # TODO.md # config/api_platform/media.yaml # config/api_platform/playlist_screen_region.yaml # config/api_platform/playlist_slide.yaml # config/api_platform/screen_groups.yaml # config/api_platform/screen_layout_regions.yaml # config/api_platform/tenant.yaml # src/Serializer/RelationNormalizer.php # tests/Api/PlaylistScreenRegionTest.php # tests/Api/PlaylistsTest.php
4 tasks
|
@tuj, please review this. |
tuj
requested changes
Nov 17, 2023
|
|
||
| class ScreenCampaign | ||
| { | ||
| use BlameableTrait; |
There was a problem hiding this comment.
Why use traits here and not in the other DTOs?
There was a problem hiding this comment.
Yeah, why not? Fixed in bc2e1b9.
The traits came about as a desperate attempt to fix something that may be broken in the API (cf. os2display/display-admin-client#223).
src/Entity/AbstractBaseEntity.php
Outdated
| * @ORM\PrePersist() | ||
| */ | ||
| public function setCreatedAtValue(): self | ||
| // FIXME Why can't I #[Ignare] this function? |
There was a problem hiding this comment.
I need (new) glasses! 985bd3c
src/State/AbstractProcessor.php
Outdated
| /** | ||
| * Load previous object if any. | ||
| * | ||
| * This is needed to get an objet handled by entity manager. |
src/Entity/AbstractBaseEntity.php
Outdated
| * @ORM\PreUpdate() | ||
| */ | ||
| public function setModifiedAtValue(): self | ||
| // FIXME Why can't I #[Ignare] this function? |
There was a problem hiding this comment.
I need (new) glasses! 985bd3c
tests/Api/SlidesTest.php
Outdated
| 'published' => 'Slide/published', | ||
| 'content' => 'Slide/content', | ||
| ], | ||
| // FIXME: What is the correct context? |
There was a problem hiding this comment.
Remove this commented out code. Let's ignore context in tests
tuj
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://jira.itkdev.dk/browse/DISPLAY-1030
Description
Upgrades to API Platform 3.
Screenshot of the result
If your change affects the user interface you should include a screenshot of the result with the pull request.
Checklist
If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.
Notes on API spec
authentication-token(https://github.com/os2display/display-api-service/blob/develop/config/routes.yaml#L8-L11) suddenly appears in the API spec (!)