DISPLAY-1030: Remaining updates, cleanup deprectaions #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turegjorup
changed the title
rimi-itk
approved these changes
Nov 24, 2023
| $this->addSql('ALTER TABLE user_role_tenant CHANGE roles roles LONGTEXT NOT NULL COMMENT \'(DC2Type:array)\''); | ||
| } | ||
|
|
||
| private function convertDbValues(string $table, string $column): void |
There was a problem hiding this comment.
A little documentation block here telling what this function does would be handy. The code (and inline comments) tell what is done, but a short recap would be nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://jira.itkdev.dk/browse/DISPLAY-1030
Description
symfony/flex1.x -> 2.xvich/uploader-bundle1.x -> 2.xdebril/feed-io5.x -> 6.xScreenshot of the result
If your change affects the user interface you should include a screenshot of the result with the pull request.
Checklist
If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.
Additional comments or questions
If you have any further comments or questions for the reviewer please add them here.