Skip to content

Added media and content to slide serialization #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 7, 2023

Conversation

rimi-itk
Copy link
Contributor

@rimi-itk rimi-itk commented Dec 6, 2023

Link to ticket

https://jira.itkdev.dk/browse/DISPLAY-1088

Description

  • Adds media and content to slide serialization
  • Expands objects in collections

Screenshot of the result

If your change affects the user interface you should include a screenshot of the result with the pull request.

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.

Additional comments or questions

If you have any further comments or questions for the reviewer please add them here.

@rimi-itk rimi-itk force-pushed the feature/DISPLAY-1088-dto-4 branch from 4f76700 to cc3f3e6 Compare December 6, 2023 09:17
@rimi-itk rimi-itk force-pushed the feature/DISPLAY-1088-dto-4 branch from cc3f3e6 to 95a0103 Compare December 6, 2023 09:20
@rimi-itk rimi-itk force-pushed the feature/DISPLAY-1088-dto-4 branch from 67b87fb to 8b6611d Compare December 6, 2023 12:47
@rimi-itk rimi-itk marked this pull request as ready for review December 6, 2023 15:23
@rimi-itk rimi-itk requested a review from tuj December 6, 2023 15:24
@@ -57,4 +58,9 @@ public function provideCollection(Operation $operation, array $uriVariables = []

return new Paginator($doctrinePaginator);
}

public function toOutput(object $object): object
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return type should be a DTO ?

Copy link
Contributor

@tuj tuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with a comment

@rimi-itk rimi-itk requested a review from tuj December 7, 2023 08:49
@tuj tuj merged commit ac3d98c into os2display:develop Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants