Skip to content

2134: Fixed sql error in relations modified listener #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2024
Merged

2134: Fixed sql error in relations modified listener #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.

## [Unreleased]

## [2.0.7] - 2024-08-20

- [#211](https://github.com/os2display/display-api-service/pull/211)
- Fixed sql error in relations modified listener

## [2.0.6] - 2024-06-28

- [#208](https://github.com/os2display/display-api-service/pull/208)
Expand Down
18 changes: 10 additions & 8 deletions src/EventListener/RelationsChecksumListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ private static function getToOneQuery(string $jsonKey, string $parentTable, stri
* INNER JOIN (
* SELECT
* c.playlist_id,
* CAST(GROUP_CONCAT(c.changed SEPARATOR "") > 0 AS UNSIGNED) changed,
* CAST(GROUP_CONCAT(DISTINCT c.changed SEPARATOR "") > 0 AS UNSIGNED) changed,
* SHA1(GROUP_CONCAT(c.id, c.version, c.relations_checksum)) checksum
* FROM
* playlist_slide c
Expand All @@ -392,10 +392,11 @@ private static function getToOneQuery(string $jsonKey, string $parentTable, stri
* Explanation:
* Because this is a "to many" relation we need to GROUP_CONCAT values from the child relations. This is done in a temporary table
* with GROUP BY parent id in the child table. This gives us just one child row for each parent row with a checksum from the relevant
* fields across all child rows.
* fields across all child rows. We use a DISTINCT clause in GROUP_CONCAT to limit the length of the resulting value and avoid
* illegal integer values.
*
* This temp table is then joined to the parent table to allow us to SET the p.changed and p.relations_checksum values on the parent.
* - Because GROUP_CONCAT will give us all child rows "changed" as one, e.g. "00010001" we need "> 0" to ecaluate to true/false
* - Because GROUP_CONCAT will give us all child rows "changed" as one, e.g. "00010001" we need "> 0" to evaluate to true/false
* and then CAST that to "unsigned" to get a TINYINT (bool)
* WHERE either p.changed or c.changed is true
* - Because we can't easily get a list of ID's of affected rows as we work up the tree we use the bool "changed" as clause in
Expand All @@ -413,7 +414,7 @@ private static function getOneToManyQuery(string $jsonKey, string $parentTable,
INNER JOIN (
SELECT
c.%s,
CAST(GROUP_CONCAT(c.changed SEPARATOR "") > 0 AS UNSIGNED) changed,
CAST(GROUP_CONCAT(DISTINCT c.changed SEPARATOR "") > 0 AS UNSIGNED) changed,
SHA1(GROUP_CONCAT(c.id, c.version, c.relations_checksum)) checksum
FROM
%s c
Expand Down Expand Up @@ -448,7 +449,7 @@ private static function getOneToManyQuery(string $jsonKey, string $parentTable,
* INNER JOIN (
* SELECT
* pivot.slide_id,
* CAST(GROUP_CONCAT(c.changed SEPARATOR "") > 0 AS UNSIGNED) changed,
* CAST(GROUP_CONCAT(DISTINCT c.changed SEPARATOR "") > 0 AS UNSIGNED) changed,
* SHA1(GROUP_CONCAT(c.id, c.version, c.relations_checksum)) checksum
* FROM
* slide_media pivot
Expand All @@ -463,10 +464,11 @@ private static function getOneToManyQuery(string $jsonKey, string $parentTable,
* Explanation:
* Because this is a "to many" relation we need to GROUP_CONCAT values from the child relations. This is done in a temporary table
* with GROUP BY parent id in the child table. This gives us just one child row for each parent row with a checksum from the relevant
* fields across all child rows.
* fields across all child rows. We use a DISTINCT clause in GROUP_CONCAT to limit the length of the resulting value and avoid
* illegal integer values.
*
* This temp table is then joined to the parent table to allow us to SET the p.changed and p.relations_checksum values on the parent.
* - Because GROUP_CONCAT will give us all child rows "changed" as one, e.g. "00010001" we need "> 0" to ecaluate to true/false
* - Because GROUP_CONCAT will give us all child rows "changed" as one, e.g. "00010001" we need "> 0" to evaluate to true/false
* and then CAST that to "unsigned" to get a TINYINT (bool)
* WHERE either p.changed or c.changed is true
* - Because we can't easily get a list of ID's of affected rows as we work up the tree we use the bool "changed" as clause in
Expand All @@ -485,7 +487,7 @@ private static function getManyToManyQuery(string $jsonKey, string $parentTable,
INNER JOIN (
SELECT
pivot.%s,
CAST(GROUP_CONCAT(c.changed SEPARATOR "") > 0 AS UNSIGNED) changed,
CAST(GROUP_CONCAT(DISTINCT c.changed SEPARATOR "") > 0 AS UNSIGNED) changed,
SHA1(GROUP_CONCAT(c.id, c.version, c.relations_checksum)) checksum
FROM
%s pivot
Expand Down
Loading